You are viewing an historical archive of past issues. Please report new issues to the appropriate project issue tracker on GitHub.

Bug #2191: CommandTMaxHeight not taken into account

Kind bug
Product Command-T
When Created , updated
Status closed
Reporter Andri Moell
Tags no tags

Description

Hey,

Is it me or is CommandTMaxHeight no longer working on the MacVim snapshot 73? It used to work okay on 70. Even with a basic vimrc it doesn't seem to limit the height. At least on my system. 

set nocompatible
set rtp+=~/.vim/bundle/command-t
let CommandTMaxHeight=20

Comments

  1. Greg Hurrell

    I just tried it out with the version of MacVim I have (installed via Homebrew, it's 7.4 with patches 1-258, and the folder it's installed into is "7.4-73_1", which I suppose corresponds to snapshot 73), and it works.

    In my vimrc I have let g:CommandTMaxHeight=30. I open Command-T and see 30 entries in the list, then I do: 

    :let g:CommandTMaxHeight=5
:CommandTFlush

    and open it again and see only 5 entries.

    I see you don't have an explicit g: prefix in your example, but I'd expect it to work either way.

  2. Andri Moell

    Turned out to be a compile mismatch. The matcher.c was compiled against Ruby v1.9.3 from Homebrew, yet the Mac ships with Ruby 2.0 and/or MacVim depends on Ruby 2.0 nowadays. Everything worked except all values out of the passed-in option hash were read as nil in C. Limit was therefore ignored.

    Not your fault, of course. Just the fucking software ecosystem in general is way too intertwined and fragile these days. ;-)

  3. Andri Moell

    I don't think I can close this bug myself. Please do it for me. Thanks! One more reason to use a ready made issue tracker or migrate over to one of those code hosting sites. ;-)

  4. Greg Hurrell

    Yep, I'll close it. Glad to hear you got it working.

  5. Greg Hurrell

    Status changed:

    • From: new
    • To: closed
Add a comment

Comments are now closed for this issue.

Menu