You are viewing an historical archive of past issues. Please report new issues to the appropriate project issue tracker on GitHub.

Bug #2133: Evaluation of PROCESSOR_COUNT during build time is wrong

Kind bug
Product Command-T
When Created , updated
Status closed
Reporter Vit Ondruch
Tags no tags

Description

You assume, that the Ruby extension is build on the same machine, where the code is executed. This assumption is invalid for Fedora. When I package command-t for use with Fedora, the extension is built on Koji builder. There might be powerful CPUs with plenty of cores, but it says nothing about my machine. Could you please consider to update this logic somehow?

Comments

  1. Greg Hurrell

    My concern is that the logic is complicated, brittle, and potentially expensive, so I preferred to reduce the exposure by running it only once, at build time, rather than at run time.

    But I see your point. I'll see what I can do.

  2. Greg Hurrell

    I am thinking of applying something like this patch.

  3. Greg Hurrell

    I decided to run with the patch, and have released 1.6.1.

    Marking this ticket as closed.

  4. Greg Hurrell

    Status changed:

    • From: new
    • To: closed
  5. Vit Ondruch

    Thank you. I have not a chance to test the change yet, but it looks reasonable.

Add a comment

Comments are now closed for this issue.

Menu