≡

wincent.dev

  • Products
  • Blog
  • Wiki
  • Issues
You are viewing an historical archive of past issues. Please report new issues to the appropriate project issue tracker on GitHub.
Home » Issues » Bug #1888

Bug #1888: Executing Rakefile fails on Windows 7 x64

Kind bug
Product Command-T
When Created 2011-10-05T18:11:05Z, updated 2011-10-09T05:47:23Z
Status closed
Reporter anonymous
Tags no tags

Description

I tried to run rake make from the default Windows command promt (cmd.exe) but it fails during executing Rakefile and before running make. I fixed it like this:

diff --git a/Rakefile b/Rakefile
index 3aa7095..c8f722a 100644
--- a/Rakefile
+++ b/Rakefile
@@ -134,7 +134,8 @@ desc 'Compile extension'
 task :make do
   Dir.chdir 'ruby/command-t' do
     ruby 'extconf.rb'
-    system 'make clean && make'
+    system 'make clean '
+    system 'make'
     bail_on_failure
   end
 end

IMHO it seems that the command prompt cannot join commands with &&.

Comments

  1. Greg Hurrell 2011-10-09T05:26:23Z

    Seems like a reasonable change which at best will fix things for you on Windows, and at worst won't break it for anybody else, so I'll add it.

  2. Greg Hurrell 2011-10-09T05:34:49Z

    Committed the change here with a small tweak (you need a call to bail_on_failure to preserve the exit-on-failure semantics of &&):

    • https://wincent.dev/repos/command-t/commits/f19aee00f6b7a9c451a7aa168e05f0cdd0d99374

    It will be included in the next release.

    Marking this issue as closed.

  3. Greg Hurrell 2011-10-09T05:47:23Z

    Status changed:

    • From: new
    • To: closed
Add a comment

Comments are now closed for this issue.

  • contact
  • legal

Menu

  • Blog
  • Wiki
  • Issues
  • Snippets