You are viewing an historical archive of past issues. Please report new issues to the appropriate project issue tracker on GitHub.

Bug #1734: commits#show chokes on mode-changing diffs

Kind bug
Product wincent.dev
When Created , updated
Status closed
Reporter Greg Hurrell
Tags no tags

Description

This commit, for example: 

commit 3870f90b262cf825e6dfdd83090626cf1e5826d5
Author: Greg Hurrell <greg@hurrell.net>
Date:   Mon Feb 18 22:47:22 2008 +0100

    Correct file mode on spec files
    
    Two spec files were missing the executable bit.
    
    Signed-off-by: Greg Hurrell <greg@hurrell.net>

diff --git a/spec/indentation_spec.rb b/spec/indentation_spec.rb
old mode 100644
new mode 100755
diff --git a/spec/regressions_spec.rb b/spec/regressions_spec.rb
old mode 100644
new mode 100755

Raises a Git::Commit::MalformedDiffError, with message, "malformed diff output for line: diff --git a/spec/regressions_spec.rb b/spec/regressions_spec.rb".

Comments

  1. Greg Hurrell

    Summary changed:

    • From: commits#show chokes on diffs mode-changing diffs
    • To: commits#show chokes on mode-changing diffs
  2. Greg Hurrell

    Raw output:

    $ git diff-tree --numstat -p --patience --root 3870f90b262cf825e6dfdd83090626cf1e5826d5
3870f90b262cf825e6dfdd83090626cf1e5826d5
0	0	spec/indentation_spec.rb
0	0	spec/regressions_spec.rb

diff --git a/spec/indentation_spec.rb b/spec/indentation_spec.rb
old mode 100644
new mode 100755
diff --git a/spec/regressions_spec.rb b/spec/regressions_spec.rb
old mode 100644
new mode 100755
  3. Greg Hurrell

    Ok, the crash is fixed. The actual diff output for these mode-only-changes isn't very interesting though. Will open a separate ticket for that.

  4. Greg Hurrell

    Status changed:

    • From: new
    • To: closed
Add a comment

Comments are now closed for this issue.

Menu