You are viewing an historical archive of past issues. Please report new issues to the appropriate project issue tracker on GitHub.

Feature request #1261: Enable blog comments

Kind feature request
Product wincent.dev
When Created , updated
Status closed
Reporter Greg Hurrell
Tags no tags

Description

So, blog comments are currently implemented (and have been for a long time), but I've never published any posts with commenting enabled and I don't plan to until some issues have been fixed.

  1. The CSS is ugly; it should be changed to match the comment styling used in the issue tracker.
  2. The comment-count display in the show template is unnecessarily complex (from a UI perspective, it adds little value; and from a database perspective, it produces 3 extremely similiar SELECT count(*) queries), and could probably be ditched entirely.
  3. There is an "N+1 SELECT" problem, with one SELECT * FROM `users` for each comment.

Other than that, it's probably all ok.

Comments

  1. Greg Hurrell

    Status changed:

    • From: New
    • To: Open
  2. Greg Hurrell

    Another thing I forgot to mentioned: the comments use hard-coded relative dates; they should be JS-driven.

  3. Greg Hurrell
    • Ugly CSS: fixed.
    • Unnecessary comment count: removed.
    • Hard-coded relative dates: replaced.
  4. Greg Hurrell
    • "N+1 SELECT": fixed.
  5. Greg Hurrell

    Ok, going to roll this out in the next deployment, so marking this as closed.

  6. Greg Hurrell

    Status changed:

    • From: Open
    • To: Closed
  7. Greg Hurrell

    Deployed.

Add a comment

Comments are now closed for this issue.

Menu